DC API Root URI changed #7
Conversation
📝 WalkthroughWalkthroughUpdated the base API URL constant in Desertcart::Client from https://api.desertcart.com/api to https://desertcart.ae/api. No other logic or method behavior changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
lib/desertcart/client.rb(1 hunks)
🔇 Additional comments (2)
lib/desertcart/client.rb (2)
7-7: LGTM: Base URL updated to new DC API rootThe constant update to https://desertcart.ae/api aligns with the incident and should unblock requests.
url_from_pathstill guarantees exactly one slash when joining, so no downstream callsites need changes.
7-7: No hard-coded hosts remain outsidelib/desertcart/client.rb
A repository-wide search (including tests, docs, fixtures, VCR cassettes, etc.) for both the old host (api.desertcart.com) and the new host (desertcart.ae/api) returned no matches outside of the updated client file. Everything looks up-to-date.
| include LedgerSync::Ledgers::Client::Mixin | ||
|
|
||
| ROOT_URI = 'https://api.desertcart.com/api' | ||
| ROOT_URI = 'https://desertcart.ae/api' |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Make API root configurable to avoid future hotfixes
Recommend reading the base URL from an environment variable with a sane default. This avoids code changes if the host moves again (staging/region cutovers, failover, etc.).
Apply within this line:
-ROOT_URI = 'https://desertcart.ae/api'
+ROOT_URI = ENV.fetch('DESERTCART_API_ROOT_URI', 'https://desertcart.ae/api')If you want, I can add a short README snippet and example dotenv entry.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ROOT_URI = 'https://desertcart.ae/api' | |
| ROOT_URI = ENV.fetch('DESERTCART_API_ROOT_URI', 'https://desertcart.ae/api') |
🤖 Prompt for AI Agents
In lib/desertcart/client.rb around line 7, the hardcoded ROOT_URI should be made
configurable by reading an environment variable with a sensible default; replace
the literal with code that reads ENV['DESERTCART_API_ROOT'] (or similar, e.g.
DESERTCART_API_URL) and falls back to 'https://desertcart.ae/api' so deployments
can override the base API root without changing code, and update any README or
dotenv examples accordingly.
We started to have issues on DB during sync with DC:
Couldn't resolve host name.The URI changed to
desertcart.ae/apiIssue slack: https://desertcartuae.slack.com/archives/C037UTHFU4W/p1755679371967219
Example: https://dropbot.sh/admin/trail/logs/68a593f1d991130007a70c5a