Ordering API: Add missing properties #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeuleya
force-pushed
the
bugfix/add_missing_properties_on_ordering_api
branch
from
f6bf3b4 to
aef670c
Compare
jkeuleya
force-pushed
the
bugfix/add_missing_properties_on_ordering_api
branch
from
2f5640c to
fd3ee66
Compare
jkeuleya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KostasKostogloy WIP because
references_manyraises an error when we don't receive them in the API's response.We can rescue
attributebut I don't think we can rescuereferences_many. Jozef told me that it's a known issue and that I can timebox myself to fix it in the LS gem directly.EDIT: Fix waiting to be reviewed: LedgerSync/ledger_sync#322
Beside that, everything's present in this PR ! You can still review it :)
EDIT 2: Commented the problematic lines, we can ship it.