Open
Conversation
Always log the intended message (use Python logging mechanism to control whether the log message is emitted) Use the debug flag strictly to control whether or not the UDP message is sent.
Owner
|
Seems reasonable. I'm worried about the inefficiency in doing the string substitution operation for a log message that will almost always be ignored. Can you replace % with , so that the string substitution is delayed until the logging module wants to do it, please? The other thing I'm concerned about is generating noise by default. Do you think it should be quiet by default? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always log the intended message (use Python logging mechanism to control whether the log message is emitted)
Use the debug flag strictly to control whether or not the UDP message is sent.
I found it a big confusing that the debug flag affected the ultimate functionality, I guess it's being used as a "test" flag in actuality. I think it's helpful to be able to debug log the message even when it's actually being sent, and if I want to squelch it, I can tell Python logging to do that.