SASL Digest-MD5 for the ZK Quorum#189
Open
JeanMichelApeupres wants to merge 1 commit intoderic:masterfrom
Open
SASL Digest-MD5 for the ZK Quorum#189JeanMichelApeupres wants to merge 1 commit intoderic:masterfrom
JeanMichelApeupres wants to merge 1 commit intoderic:masterfrom
Conversation
deric
requested changes
May 31, 2023
JeanMichelApeupres
force-pushed
the
master
branch
from
1dd84c3 to
a15f767
Compare
deric
reviewed
Jun 1, 2023
| Boolean $quorum_auth_enable_sasl = $zookeeper::params::quorum_auth_enable_sasl, | ||
| Boolean $quorum_auth_learner_require_sasl = $zookeeper::params::quorum_auth_learner_require_sasl, | ||
| Boolean $quorum_auth_server_require_sasl = $zookeeper::params::quorum_auth_server_require_sasl, | ||
| String $quorum_sasl_user = $zookeeper::params::quorum_sasl_user, |
Owner
There was a problem hiding this comment.
String can't have an undef value unless it's declared as Optional[String]. The same in case of $quorum_sasl_password
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
Since ZK 3.4.10, we can have SASL authentication for the quorum (more information here : https://cwiki.apache.org/confluence/display/ZOOKEEPER/Server-Server+mutual+authentication). This PR implements SASL for server2server authentication using Digest-MD5 but can be improved to include Kerberos (I don't have Kerberos in my testing environment) :)