Add admin server options from ZK 3.5.5 - update#140
Open
hdeadman wants to merge 5 commits intoderic:masterfrom
Open
Add admin server options from ZK 3.5.5 - update#140hdeadman wants to merge 5 commits intoderic:masterfrom
hdeadman wants to merge 5 commits intoderic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the PR to avoid adding the admin block if install-method is package and version is pinned to < 3.5.5. Is it OK to default to including the admin block if they don't specify any version (e.g. install_method=package and ensure=present)? They still have option to disable the admin block by disabling the admin server which will leave the block out regardless of version.