Skip to content

Improve CI #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deraldosp merged 6 commits into from
Apr 4, 2022
Merged

Improve CI #5

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bdd3c94
Improve CI
deraldosp Apr 4, 2022
57ab1e7
Update .github/workflows/node.js.yml
deraldosp Apr 4, 2022
6dad3fe
Improve CI with build and test separataly
deraldosp Apr 4, 2022
dc822f8
Update node.js.yml
deraldosp Apr 4, 2022
cf6c4ef
Update .github/workflows/node.js.yml
deraldosp Apr 4, 2022
a9d83d2
Update .github/workflows/node.js.yml
deraldosp Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,39 @@ on:
branches: [ main ]

jobs:
build:

build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: npm install and build webpack
run: |
npm install
npm run build
- uses: actions/upload-artifact@main
with:
name: webpack artifacts
needs: build

- uses: actions/upload-artifact@master
with:
name: webpack artifacts
path: public/
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

os: [ubuntu-latest, windows-2016]
node-version: [12.x, 14.x]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Copy link
Copy Markdown
Contributor

@github-learning-lab github-learning-lab bot Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit this suggestion directly.

Suggested change
- name: Use Node.js ${{ matrix.node-version }}
- uses: actions/download-artifact@main
with:
name: webpack artifacts
path: public
- name: npm install, and test

uses: actions/setup-node@v3
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: npm ci
- run: npm run build --if-present
- run: npm test
- name: npm install, and test
run: |
npm install
npm test
env:
CI: true