Initial Release Candidate #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the initial release candidate for PandaGarage with a complete set of new HTML pages for the user interface, localization support across multiple languages, and updated build and configuration files. Key changes include the addition of pages for settings, logs, information, authentication, a captive portal, and updated CI/CD build scripts.
Reviewed Changes
Copilot reviewed 65 out of 65 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| data/settings/ha.html | New Home Assistant settings page with duplicate favicon tags detected. |
| data/settings/device.html | New device configuration page with redundant favicon links. |
| data/logs.html | Added logs page; duplicate favicon links appear in head section. |
| data/logs-live.html | Introduced live logs page; redundant favicon link tags found. |
| data/info.html | New information page; repeated favicon elements noted. |
| data/index.html | New dashboard page; contains multiple favicon tag redundancies. |
| data/captive.html | Captive portal page; duplicate favicon tags are present. |
| data/auth.html | Authentication page; duplicate favicon lines detected. |
| data/404.html | 404 error page; contains repeated favicon tags. |
| data/LICENSE | License file text uses an unexpected project name. |
| .github/workflows/build.yml | Build workflow setup for firmware and filesystem builds. |
| data/assets/js/i18n/* | New localization files in multiple languages. |
| README.md | Updated project overview and contributing information. |
| .clang-format | Added clang-format configuration. |
Comments suppressed due to low confidence (1)
LICENSE:3
- The license text refers to 'PandaLED' instead of 'PandaGarage', which may be a naming error; ensure the project name is consistent across documentation.
This work, PandaLED, a firmware for a custom ESP32 PCB, is licensed under the Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International License.
Comment on lines
+9
to
+11
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> |
There was a problem hiding this comment.
[nitpick] Duplicate favicon link tags are present; consider removing redundant tags to simplify the head section.
Suggested change
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> |
Comment on lines
+9
to
+11
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> |
There was a problem hiding this comment.
[nitpick] The favicon link is duplicated multiple times; removing unnecessary duplicates will improve code clarity.
Suggested change
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="../assets/img/icon.svg"> |
Comment on lines
+9
to
+11
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
There was a problem hiding this comment.
[nitpick] Multiple favicon link tags are defined; consider consolidating them into a single entry to enhance maintainability.
Suggested change
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
Comment on lines
+9
to
+11
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
There was a problem hiding this comment.
[nitpick] Redundant favicon links are present; removing duplicates could reduce clutter in the head section.
Suggested change
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
Comment on lines
+9
to
+11
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
There was a problem hiding this comment.
[nitpick] There are multiple favicon link tags; consider keeping only one to avoid unnecessary duplication.
Suggested change
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
Comment on lines
+9
to
+11
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
There was a problem hiding this comment.
[nitpick] Duplicate favicon tags appear in the head section; removing the extra tags may improve code clarity.
Suggested change
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
Comment on lines
+10
to
+12
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
There was a problem hiding this comment.
[nitpick] The favicon is declared multiple times; consider eliminating redundant entries for maintainability.
Suggested change
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
Comment on lines
+9
to
+11
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
There was a problem hiding this comment.
[nitpick] There are duplicate favicon link tags; it is recommended to keep a single favicon definition to reduce redundancy.
Suggested change
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
Comment on lines
+9
to
+11
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | ||
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
There was a problem hiding this comment.
[nitpick] Multiple favicon links appear in the head; consider removing duplicate entries to clean up the markup.
Suggested change
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> | |
| <link rel="icon" type="image/svg+xml" sizes="167x150" href="assets/img/icon.svg"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First working release candidate
Still under development: