Skip to content

fix(testing): strip relative paths (as well as file:// paths) from snapshot test subprocess stderr #7081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dandv wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(testing): strip relative paths (as well as file:// paths) from snapshot test subprocess stderr #7081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions testing/snapshot_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
}

function formatTestError(string: string) {
// Strip colors and remove "Check file:///workspaces/deno_std/testing/.tmp/test.ts"
// Strip colors and remove "Check <path>" lines
// as this is always output to stderr
return stripAnsiCode(string).replace(/^Check file:\/\/(.+)\n/gm, "");
return stripAnsiCode(string).replace(/^Check .+\n/gm, "");
}

function testFnWithTempDir(
Expand Down Expand Up @@ -326,7 +326,7 @@
});
`);

const { snapshot } = await import(toFileUrl(snapshotFilePath).toString());

Check warning on line 329 in testing/snapshot_test.ts

View workflow job for this annotation

GitHub Actions / test (canary, ubuntu-latest) 

unable to analyze dynamic import

await assertSnapshot(t, snapshot[`${snapshotName} 1`]);
await assertSnapshot(t, formatTestOutput(result.output));
Expand Down
Loading