change view to reshape to support channels last#27
Open
chunyuan-w wants to merge 1 commit intodenisyarats:masterfrom
Open
change view to reshape to support channels last#27chunyuan-w wants to merge 1 commit intodenisyarats:masterfrom
chunyuan-w wants to merge 1 commit intodenisyarats:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
drqdoes not support channels last input sinceviewhas constraints on the input size and stride (https://pytorch.org/docs/stable/generated/torch.Tensor.view.html):Change
viewtoreshapewhich returns a view if the shapes are compatible, and copies (equivalent to callingcontiguous()) otherwise.