Skip to content

Updated because messages, to have a clear Violation message #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moritzLanger wants to merge 1 commit into
base: add-third-party-violations
Choose a base branch
from
Open

Updated because messages, to have a clear Violation message #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/test/java/com/devonfw/sample/archunit/ThirdPartyRulesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,18 @@ public class ThirdPartyRulesTest {
@ArchTest
public static ArchRule check_object_dependency = noClasses().should().dependOnClassesThat()
.haveFullyQualifiedName("com.google.common.base.Objects")
.because("Use Java standards instead (java.util.Objects).");
.because("the Java standards should be used instead (java.util.Objects).");

@ArchTest
public static ArchRule check_converter_dependency = noClasses().should().dependOnClassesThat()
.haveFullyQualifiedName("javax.persistence.Convert")
.because("Use the javax.persistence.Converter annotation on a custom converter"
.because("the javax.persistence.Converter annotation should be used on a custom converter"
+ " which implements the javax.persistence.AttributeConverter instead of the 'javax.persistance.Convert' annotation");

@ArchTest
public static ArchRule check_mysema_dependency = noClasses().should().dependOnClassesThat()
.resideInAPackage("com.mysema.query..")
.because("Use official QueryDSL (com.querydsl.* e.g. from com.querydsl:querydsl-jpa).");
.because("the official QueryDSL should be used (com.querydsl.* e.g. from com.querydsl:querydsl-jpa).");

private static boolean isApiScopedClassUsingTransactional(JavaClass source, String targetPackageFullName) {

Expand Down Expand Up @@ -227,4 +227,4 @@ public void check(JavaClass source, ConditionEvents events) {

@ArchTest
public static final ArchRule jpaIsUsedAsEncouraged = noClasses().should(misUseHibernate).allowEmptyShould(true);
}
}