Closed
Conversation
bbbec65 to
a18d3b7
Compare
a18d3b7 to
4570ccb
Compare
6de6e7d to
3096cac
Compare
3096cac to
5a8614e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the DELTACAST VideoMaster operators from GXF-based codelets to native Holoscan operators. The conversion removes dependency on the GXF extension system and implements direct operator functionality within the Holoscan framework.
- Converts GXF codelets to native Holoscan operators with standard lifecycle methods
- Removes GXF extension infrastructure and associated build dependencies
- Adds new deltacast_receiver application to demonstrate input functionality
Reviewed Changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| utilities/cli/container.py | Adds duplicate device mount for DELTACAST x370 hardware |
| operators/deltacast_videomaster/*.hpp | Converts operator headers from GXF to native implementation |
| operators/deltacast_videomaster/*.cpp | Converts operator implementations with new compute/lifecycle methods |
| operators/deltacast_videomaster/videomaster_base.* | New base class for shared DELTACAST functionality |
| gxf_extensions/deltacast_videomaster/* | Removes entire GXF extension codebase |
| applications/deltacast_receiver/* | Adds new receiver application for video input |
| applications/deltacast_transmitter/* | Updates transmitter to use native operators |
| applications/endoscopy_tool_tracking/* | Updates to use native operators |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Thomas Dethier <130673120+thomasdethier@users.noreply.github.com>
Collaborator
Author
|
Closing PR following creation of PR in NVIDIA repository for reintegration into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.