Skip to content

Fix hanging tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasvanmol merged 1 commit into from
Feb 13, 2025
Merged

Fix hanging tests #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions deathstar_hotel_reservation/entities/user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ def order_compiled_entry_1(variable_map: dict[str, Any], state: User) -> Any:
pass

def order_compiled_if_cond(variable_map: dict[str, Any], state: User) -> Any:
return variable_map["hotel_reserve"] and variable_map["flight_reserve"]

def order_compiled_if_cond_parallel(variable_map: dict[str, Any], state: User) -> Any:
return variable_map["reserves"][0] and variable_map["reserves"][1]
# parallel
if "reserves" in variable_map:
return variable_map["reserves"][0] and variable_map["reserves"][1]
else:
return variable_map["hotel_reserve"] and variable_map["flight_reserve"]

def order_compiled_if_body(variable_map: dict[str, Any], state: User) -> Any:
return True
Expand All @@ -48,8 +49,7 @@ def order_compiled_else_body(variable_map: dict[str, Any], state: User) -> Any:
"login": check_compiled,
"order_compiled_entry_0": order_compiled_entry_0,
"order_compiled_entry_1": order_compiled_entry_1,
# "order_compiled_if_cond": order_compiled_if_cond,
"order_compiled_if_cond": order_compiled_if_cond_parallel,
"order_compiled_if_cond": order_compiled_if_cond,
"order_compiled_if_body": order_compiled_if_body,
"order_compiled_else_body": order_compiled_else_body
},
Expand Down
10 changes: 9 additions & 1 deletion deathstar_movie_review/test_movie_review_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,19 @@
from deathstar_movie_review.entities.compose_review import ComposeReview, compose_review_op
from deathstar_movie_review.entities.user import User, user_op
from deathstar_movie_review.entities.movie import MovieId, movie_id_op, movie_info_op, plot_op
from deathstar_movie_review.entities.frontend import frontend_op, text_op, unique_id_op
from deathstar_movie_review.entities.frontend import frontend_op, text_op, unique_id_op, frontend_df_serial



def test_deathstar_movie_demo_python():
print("starting")
runtime = PythonRuntime()

# make sure we're running the serial version
prev_df = frontend_op.dataflow
frontend_op.dataflow = frontend_df_serial()


print(frontend_op.dataflow.to_dot())
dead_node_elimination([], [frontend_op])
print(frontend_op.dataflow.to_dot())
Expand Down Expand Up @@ -98,4 +103,7 @@ def test_deathstar_movie_demo_python():
assert result == expected

print("Success!")

# put the df back
frontend_op.dataflow = prev_df

Loading