Rate Limiting Middleware for Protected Endpoints #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements custom rate limiting middleware for OnChain Sage to prevent abuse on high-impact routes.
Changes
Added IP/wallet-based rate limiting via @nestjs/throttler to guard POST /signal, /vote, and /webhook endpoints
Created database entity and migration for rate_limit_violations table
Implemented Redis-backed throttler for distributed scaling
Added comprehensive unit and integration tests (100% coverage)
Technical Details
Rate limits default to 10 requests/60s, configurable via environment variables
Prioritizes wallet address over IP when available
Logs violation details including IP, wallet, timestamp, endpoint, and violated rule
Automatically returns 429 responses when limits exceeded
Testing
Unit tests verify middleware logic and repository interactions
E2E tests confirm rate limiting works across all protected routes
Tested with different rate limit configurations and client identifiers
Closes #183