Updaing code to use OAuth2 API and some new features#2
Open
btamburrino wants to merge 3 commits intodegan:masterfrom
Open
Updaing code to use OAuth2 API and some new features#2btamburrino wants to merge 3 commits intodegan:masterfrom
btamburrino wants to merge 3 commits intodegan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your code worked out of the box when I first got my car but then they got rid of the old API sometime between then and now. I updated this PHP library to use the new method. I dropped cookie support since it's now all auth token based, but didn't create a way to store the token (or specify a token) yet.
For some reason, with the ID and Secret I'm using, I can't actually test any of the commands (they return a 404) but the data_requests all work, so at least it's a start. This may help someone else.commandcalls are now all POST. I made a second commit to fix this.This addresses #1.