gui/circles: fix null-deref crash, wrong circle ID in accept/reject, deferred status update, and thread safety in CreateCircleDialog#241
Merged
defnax merged 1 commit intodefnax:circles-v1from Mar 14, 2026
Conversation
…deferred status update, and thread safety in CreateCircleDialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
returnwhen no item is selectedam_I_*variables in constructor to prevent undefined behavioram_I_circle_adminat the start of [updateMembership()] to avoid stale stateRsThread::async+usleep+postToObjectwithQTimer::singleShot(auto-cancelled on dialog destruction)