Skip to content

gui/circles: fix null-deref crash, wrong circle ID in accept/reject, deferred status update, and thread safety in CreateCircleDialog#241

Merged
defnax merged 1 commit intodefnax:circles-v1from
jolavillette:Fix_PR3174_5
Mar 14, 2026
Merged

gui/circles: fix null-deref crash, wrong circle ID in accept/reject, deferred status update, and thread safety in CreateCircleDialog#241
defnax merged 1 commit intodefnax:circles-v1from
jolavillette:Fix_PR3174_5

Conversation

@jolavillette
Copy link
Copy Markdown

  • Fix null-deref crash in [MembershipListCustomPopupMenu] — added early return when no item is selected
  • Fix [acceptInvite]/[rejectInvite] — used circle group ID instead of member key ID
  • Fix "Pending" display bug — deferred [updateMembership()] to a single call after all members are loaded in [fillIdentitiesList]
  • Init am_I_* variables in constructor to prevent undefined behavior
  • Reset am_I_circle_admin at the start of [updateMembership()] to avoid stale state
  • Thread safety — replaced RsThread::async + usleep + postToObject with QTimer::singleShot (auto-cancelled on dialog destruction)

…deferred status update, and thread safety in CreateCircleDialog
@defnax defnax merged commit ec3c3ba into defnax:circles-v1 Mar 14, 2026
1 check failed
@jolavillette jolavillette deleted the Fix_PR3174_5 branch March 18, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants