GUI: Fix PR3184 bugs (icon distortion, memory leak, nickname refresh) and optimize cache#240
Merged
defnax merged 1 commit intodefnax:circles-makecoloredgroupiconsfrom Mar 12, 2026
Conversation
… and optimize cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of improvements and fixes for PR RetroShare#3184
Following a technical review and feedback regarding UI and memory management, several improvements have been implemented:
🎨 UI & Visual Fixes
🐛 Stability & Memory
std::shared_ptrinIdDialog::updateCircles()to ensure memory is safely released even if the dialog is closed during asynchronous processing.⚡ Performance & Optimization
ORIGINAL(192px) toMEDIUM(96px). This significantly reduces RAM usage while maintaining perfect visual quality for list displays.|in cache keys to prevent theoretical collisions between different ID/Path combinations.