Open
Conversation
Contributor
mjnagel
reviewed
Jul 21, 2025
tasks/badge.yaml
Outdated
Comment on lines
292
to
299
| # Check if pods are properly enrolled in ambient mesh (they should have ztunnel connectivity) | ||
| # This is a more complex check - we'll verify by checking if the namespace has the right labels | ||
| ZTUNNEL_PODS=$(uds zarf tools kubectl get pods -n istio-system -l app=ztunnel --no-headers | wc -l) | ||
| if [ "$ZTUNNEL_PODS" -gt 0 ]; then | ||
| gh_notice " ✅ Ztunnel pods found - ambient mode infrastructure is present" | ||
| else | ||
| gh_warning " ⚠️ No ztunnel pods found - ambient mode may not be properly configured" | ||
| fi |
Collaborator
There was a problem hiding this comment.
One easy way to detect proper ambient setup is looking for the pod annotation of ambient.istio.io/redirection=enabled on all pods.
Ref: https://istio.io/latest/docs/reference/config/annotations/#AmbientRedirection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add ambient check, currently just checks istio-sidecar only
Checklist before merging