fix: add error check for keycloak admin token creation#522
Open
fix: add error check for keycloak admin token creation#522
Conversation
Signed-off-by: Brian DeGeeter <brian.degeeter@defenseunicorns.com>
Contributor
slaskawi
reviewed
Sep 2, 2025
| --data-urlencode "password=${KEYCLOAK_ADMIN_PASSWORD}" \ | ||
| --data-urlencode "client_id=admin-cli" \ | ||
| --data-urlencode "grant_type=password" | ./uds zarf tools yq .access_token) | ||
| if [ -z "${KEYCLOAK_ADMIN_ACCESS_TOKEN}" ] || [ "${KEYCLOAK_ADMIN_ACCESS_TOKEN}" = "null" ]; then |
Contributor
There was a problem hiding this comment.
The most reliable way to check if we obtained the Token is to verify the Token Endpoint return code.
I suggest we use something similar to this: https://stackoverflow.com/a/59513834
The above approach should let us verify the HTTP Return Code and if it is 200, then parse the output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added simple error check to catch failures getting KEYCLOAK_ADMIN_ACCESS_TOKEN
...
Checklist before merging