Fix DeepCompile for PyTorch 2.8/2.9 compatibility #7755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
tohtana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch 2.8 added a new static_lifetime_input_indices parameter to the partition function. This breaks DeepCompile with ZeRO stage 3.
This PR updates
partition_recompute_ds_paramsto accept**kwargsand forward them to the underlying partition function, maintaining backward compatibility with PyTorch 2.6/2.7.DeepCompile works with PyTorch v2.9 when using ZeRO Stage 1 or 2. However, ZeRO Stage 3 is not currently supported on PyTorch v2.9 (it still works on PyTorch <= v2.8). DeepCompile tests are skipped when PyTorch version is v2.9 and ZeRO stage is 3.