Skip to content

Conversation

@anyangml
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.74%. Comparing base (8d2088a) to head (90740ed).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
lambench/models/ase_models.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   64.89%   64.74%   -0.16%     
==========================================
  Files          35       35              
  Lines        1641     1645       +4     
  Branches      202      203       +1     
==========================================
  Hits         1065     1065              
- Misses        532      536       +4     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new calculator benchmark task for stacking-fault energy evaluation and integrates it into the task/metrics pipelines.

Changes:

  • Introduces a new stacking_fault calculator task that reads sliding trajectories + CSV labels and reports MAE_E and MAE_dE.
  • Adds PCHIP-based interpolation utility for smoothing/resampling energy profiles.
  • Registers the new task in calculator task config, model evaluation dispatch, and metrics metadata/post-processing.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
lambench/tasks/calculator/stacking_fault/utils.py Adds PCHIP interpolation helper used by stacking-fault metrics.
lambench/tasks/calculator/stacking_fault/stacking_fault.py Implements stacking-fault inference and metric computation.
lambench/tasks/calculator/calculator_tasks.yml Registers stacking_fault test-data location and params.
lambench/models/ase_models.py Dispatches the new task; also changes MACE head selection for inorganic domain.
lambench/metrics/results/metadata.json Adds display/description entries for stacking-fault metrics.
lambench/metrics/post_process.py Includes stacking_fault in domain-specific post-processing.
lambench/metrics/downstream_tasks_metrics.yml Adds stacking-fault to downstream task metrics config (metrics + dummy).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

anyangml and others added 4 commits January 28, 2026 15:56
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@anyangml anyangml merged commit cd98522 into deepmodeling:main Jan 28, 2026
2 of 4 checks passed
@anyangml anyangml deleted the feat/support-stacking-fault branch January 28, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant