Skip to content

Code review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camendoza94 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Code review #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cec94c4
Update style.css
camendoza94 Mar 28, 2017
6b108d2
Update main.css
camendoza94 Mar 28, 2017
1efd517
Update main.html
camendoza94 Mar 28, 2017
eb8d14e
Update style.css
camendoza94 Mar 28, 2017
d833cf6
Update transactions.js
camendoza94 Mar 28, 2017
49cfe14
Update App.jsx
camendoza94 Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion client/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/*
La aplicación tiene un diseño muy chévere. Las fuentes y colores están geniales.
La única recomendación que tengo en cuanto al diseño es disminuir el contraste entre ciertos fondos como el rojo y letra blanca para una mejor accesibilidad.
*/
body {
background-color: #fafafa;
font-family: 'Roboto Condensed', sans-serif;
Expand Down Expand Up @@ -338,4 +342,4 @@ body {
.copyRight a
{
color: #1abc9c; ;
}
}
1 change: 1 addition & 0 deletions client/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//Eliminar archivos innecesarios
/*.all {*/
/*font-family: 'Roboto', sans-serif;*/
/*}*/
Expand Down
1 change: 1 addition & 0 deletions client/main.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<!-- Bien por el uso de Google Fonts! -->
<head>
<meta charset="utf-8">

Expand Down
1 change: 1 addition & 0 deletions imports/api/transactions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// El uso de 'use strict' es recomendado. Deberían añadir un método para eliminar transacciones.
import { Meteor } from 'meteor/meteor';
import { Mongo } from 'meteor/mongo';
import { check } from 'meteor/check';
Expand Down
3 changes: 2 additions & 1 deletion imports/ui/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//Sería chévere tener la funcionalidad de eliminar y poder añadir categorías a cada transacción.
import React, {Component, PropTypes} from 'react';
import {Meteor} from 'meteor/meteor';
import {createContainer} from 'meteor/react-meteor-data';
Expand Down Expand Up @@ -461,4 +462,4 @@ export default createContainer(() =>
transactions: Transactions.find({}, {sort: {date: -1}}).fetch(),
currentUser: Meteor.user(),
};
}, App);
}, App);