Skip to content

Check confirmations for submitted unmixed utxo inputs #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrick wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check confirmations for submitted unmixed utxo inputs #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3500550
Check confirmations for submitted unmixed utxo inputs
jrick Sep 1, 2023
e31630d
add to integration tests
jrick Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion coinjoin/coinjoin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,8 @@ func verifyOutput(c Caller, outpoint *wire.OutPoint, value int64) error {
ctx, cancel := context.WithTimeout(context.Background(), rpcTimeout)
defer cancel()
var res struct {
Value float64 `json:"value"`
Value float64 `json:"value"`
Confirmations int64 `json:"confirmations"`
}
err := c.Call(ctx, "gettxout", &res, outpoint.Hash.String(), outpoint.Index, outpoint.Tree)
if err != nil {
Expand All @@ -323,6 +324,12 @@ func verifyOutput(c Caller, outpoint *wire.OutPoint, value int64) error {
nil,
}
}
if res.Confirmations <= 0 {
return &blameError{
fmt.Sprintf("output %v has not been confirmed", outpoint),
nil,
}
}
return nil
}

Expand Down
2 changes: 1 addition & 1 deletion integration/honest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ var inputValueJSON []byte
func TestMain(m *testing.M) {
flag.Parse()
inputValue = int64(*mFlag) + 1
inputValueJSON = []byte(fmt.Sprintf(`{"value":%v}`, inputValue))
inputValueJSON = []byte(fmt.Sprintf(`{"value":%v,"confirmations":1}`, inputValue))
os.Exit(m.Run())
}

Expand Down