Skip to content

update default 'mappedfile' dependency commit #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pknowles merged 1 commit into from
Oct 17, 2025
Merged

update default 'mappedfile' dependency commit #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ if(NOT TARGET decodeless::mappedfile)
FetchContent_Declare(
decodeless_mappedfile
GIT_REPOSITORY https://github.com/decodeless/mappedfile.git
GIT_TAG a6e59f8b193298a16534beab694e30ae76d7f457)
GIT_TAG a214250f70d218c055ef7b82f45f987183dceecf)
Copy link

@coderabbitai coderabbitai bot Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Consider documenting the dependency update reason.

To improve maintainability and traceability, consider adding a comment or referencing a changelog entry that explains why this dependency commit was updated (e.g., bug fixes, new features, security patches). This helps future reviewers understand the rationale for the change.

Example improvement:

      decodeless_mappedfile
      GIT_REPOSITORY https://github.com/decodeless/mappedfile.git
-     GIT_TAG a214250f70d218c055ef7b82f45f987183dceecf)
+     GIT_TAG a214250f70d218c055ef7b82f45f987183dceecf)  # Updated from a6e59f8: <reason>

Replace <reason> with a brief description of what changed (e.g., "fixes issue X" or "adds feature Y").

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In CMakeLists.txt around line 46, the pinned GIT_TAG commit for the dependency
lacks any explanation; add a one-line comment above or beside this GIT_TAG that
states the reason for the update (e.g., "update to commit a21425... — fixes
CVE-xxxx, or fixes bug #1234, or adds feature Y") and, if available, include a
short reference (PR/link or changelog entry) to the upstream change so future
reviewers can trace why this specific commit was chosen.

FetchContent_MakeAvailable(decodeless_mappedfile)
else()
message(
Expand Down