Skip to content

Add appsignal and remove sentry#157

Merged
fblupi merged 4 commits intomasterfrom
deps/appsignal
Jan 20, 2026
Merged

Add appsignal and remove sentry#157
fblupi merged 4 commits intomasterfrom
deps/appsignal

Conversation

@fblupi
Copy link
Member

@fblupi fblupi commented Dec 10, 2025

Summary by CodeRabbit

  • Chores
    • Replaced production error/monitoring gems: added AppSignal and removed Sentry and Scout APM.
    • Removed automatic request-context logging hooks from controller processing in production.
    • No public API or exported interfaces were changed; visible app behavior remains unchanged.

✏️ Tip: You can customize this high-level summary in your review settings.

@fblupi fblupi force-pushed the deps/appsignal branch 9 times, most recently from b56b05c to 42188ac Compare December 10, 2025 16:21
@fblupi fblupi requested a review from alecslupu December 10, 2025 16:38
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

Removed Sentry (sentry-raven) integration and added AppSignal by updating the Gemfile; also removed the Raven context setup and its before_action hook from DecidimController, eliminating per-request Sentry context configuration.

Changes

Cohort / File(s) Summary
Error tracking gems
Gemfile
Added appsignal gem to the production group; removed sentry-raven and scout_apm from the production group.
Controller cleanup
app/controllers/decidim_controller.rb
Removed before_action :set_raven_context and deleted the private set_raven_context method that set Raven.user_context and Raven.extra_context.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hopped through logs both near and far,
The raven left, a new bellstar,
AppSignal hums where shadows were,
I twitch my nose and give a purr,
Fresh signals bright — a rabbit's cheer! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add appsignal and remove sentry' accurately summarizes the main changes in the pull request: adding the appsignal gem and removing sentry-raven from production dependencies, along with scout_apm.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
Gemfile (1)

50-64: AppSignal configuration is missing and requires setup before deployment.

Verification confirms two issues:

  1. Missing AppSignal configuration: No config/appsignal.yml, initializer, or environment variable references exist in the codebase. AppSignal requires configuration to function—either add config/appsignal.yml with your API key, set APPSIGNAL_* environment variables in your deployment pipeline, or add an initializer in config/initializers/.

  2. APM redundancy: Both appsignal and scout_apm remain in the Gemfile and are active (scout_apm 5.7.1 is in Gemfile.lock). Remove scout_apm if fully migrating to AppSignal to eliminate redundant monitoring overhead and costs.

@andreslucena
Copy link
Member

Checking the comments from Code Rabbit:

Missing AppSignal configuration: No config/appsignal.yml, initializer, or environment variable references exist in the codebase. AppSignal requires configuration to function—either add config/appsignal.yml with your API key, set APPSIGNAL_* environment variables in your deployment pipeline, or add an initializer in config/initializers/.

I understand we don't need to do anything here, as it is defined server-side with the APPSIGNAL env vars, right?

APM redundancy: Both appsignal and scout_apm remain in the Gemfile and are active (scout_apm 5.7.1 is in Gemfile.lock). Remove scout_apm if fully migrating to AppSignal to eliminate redundant monitoring overhead and costs.

Are we still using scout_apm?

@fblupi
Copy link
Member Author

fblupi commented Jan 19, 2026

Checking the comments from Code Rabbit:

Missing AppSignal configuration: No config/appsignal.yml, initializer, or environment variable references exist in the codebase. AppSignal requires configuration to function—either add config/appsignal.yml with your API key, set APPSIGNAL_* environment variables in your deployment pipeline, or add an initializer in config/initializers/.

I understand we don't need to do anything here, as it is defined server-side with the APPSIGNAL env vars, right?

Yes, everything is configured with ENV vars in the server.

APM redundancy: Both appsignal and scout_apm remain in the Gemfile and are active (scout_apm 5.7.1 is in Gemfile.lock). Remove scout_apm if fully migrating to AppSignal to eliminate redundant monitoring overhead and costs.

Are we still using scout_apm?

Deleting scout_apm too. As far as I know we don't use it anymore as it was being used with Heroku.

@fblupi fblupi merged commit d5c2327 into master Jan 20, 2026
2 checks passed
@fblupi fblupi deleted the deps/appsignal branch January 20, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants