Conversation
b56b05c to
42188ac
Compare
42188ac to
e159a22
Compare
📝 WalkthroughWalkthroughRemoved Sentry (sentry-raven) integration and added AppSignal by updating the Gemfile; also removed the Raven context setup and its before_action hook from DecidimController, eliminating per-request Sentry context configuration. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Gemfile (1)
50-64: AppSignal configuration is missing and requires setup before deployment.Verification confirms two issues:
Missing AppSignal configuration: No
config/appsignal.yml, initializer, or environment variable references exist in the codebase. AppSignal requires configuration to function—either addconfig/appsignal.ymlwith your API key, setAPPSIGNAL_*environment variables in your deployment pipeline, or add an initializer inconfig/initializers/.APM redundancy: Both
appsignalandscout_apmremain in the Gemfile and are active (scout_apm 5.7.1is inGemfile.lock). Removescout_apmif fully migrating to AppSignal to eliminate redundant monitoring overhead and costs.
|
Checking the comments from Code Rabbit:
I understand we don't need to do anything here, as it is defined server-side with the APPSIGNAL env vars, right?
Are we still using |
Yes, everything is configured with ENV vars in the server.
Deleting |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.