fix: set tip notification amount #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ui2 with
|
| Latest commit: |
ad56f82
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://81516bac.ui2-423.pages.dev |
| Branch Preview URL: | https://fix-tip-notification-amount.ui2-423.pages.dev |
aleortega
approved these changes
Jan 22, 2026
| renderProfile?.(senderAddress) ?? | ||
| `${senderAddress.slice(0, 6)}…${senderAddress.slice(-4)}` | ||
| const manaAmount = formatMana(notification.metadata.manaAmount) | ||
| const manaAmount = Number(notification.metadata.amount).toString() |
Member
There was a problem hiding this comment.
Shall we fix precision to two decimals here? just to prevent notifications stating:
1.587892
Or you do think we need that?
| maximumFractionDigits = MAXIMUM_FRACTION_DIGITS | ||
| ): string { | ||
| return (Number(mana) / 1e18).toFixed(maximumFractionDigits).toLocaleString() | ||
| return (Number(mana) / 1e18).toFixed(maximumFractionDigits).toString() |
Member
There was a problem hiding this comment.
are we still using this format mana function somewhere else?
Member
There was a problem hiding this comment.
maybe we could enhance it to support WEI, GWEI and decimals so we don't deal with precision again
braianj
force-pushed
the
fix/tip-notification-amount
branch
from
b606e97 to
ad56f82
Compare
aleortega
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.