Skip to content

Conversation

@braianj
Copy link
Collaborator

@braianj braianj commented Nov 25, 2024

No description provided.

@braianj braianj changed the title feat: add generate:storybooks again to the cloudflare biuld feat: add generate:storybooks again to the cloudflare build Nov 25, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2024

Deploying ui2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: b0c8491
Status:🚫  Build failed.

View logs

@braianj braianj self-assigned this Nov 25, 2024
@braianj braianj added the enhancement New feature or request label Nov 25, 2024
storiesJustArgsTemplate,
storiesTemplate,
} from "./templates"
} from "./templates.ts"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it required the .ts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's because we are executing node --loader ts-node/esm ./bin/storybookGenerator.ts

@LautaroPetaccio
Copy link
Contributor

I gave it a check and some of the components are not visible in the Vercel preview:
Screenshot 2024-11-28 at 09 16 06
Screenshot 2024-11-28 at 09 15 59

Would you mind giving it a check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

No open projects
Status: Review

Development

Successfully merging this pull request may close these issues.

4 participants