feat: add SDK version support to places and destinations #782

AndresMorelos · 2026-01-13T13:11:00Z

Introduced sdk field to the places schema, allowing for filtering by SDK version.
Updated API endpoints to support SDK version filtering in destinations and places queries.
Enhanced OpenAPI documentation to include SDK version as a query parameter.
Added migration to include sdk column in the places table with appropriate indexing.
Updated relevant functions and tests to accommodate the new SDK version functionality.

- Introduced `sdk` field to the places schema, allowing for filtering by SDK version. - Updated API endpoints to support SDK version filtering in destinations and places queries. - Enhanced OpenAPI documentation to include SDK version as a query parameter. - Added migration to include `sdk` column in the places table with appropriate indexing. - Updated relevant functions and tests to accommodate the new SDK version functionality.

- Added missing imports for `destinationRoute`, `sceneStatsGenesisPlaza`, and other entities across various files. - Cleaned up import statements in `CategoryFilters`, `CategoryList`, and `OnlyViewCategoryNavbar` for better readability. - Ensured consistent import structure in `SearchList`, `UserFavorite`, and `UserLikes` routes. - Updated tests to reflect the new import structure and ensure proper functionality.

github-actions · 2026-01-13T16:34:40Z

Pull Request Test Coverage Report for Build 21249696444

Details

762 of 972 (78.4%) changed or added relevant lines in 21 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.1%) to 91.578%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/entities/Destination/utils.ts	65	71	91.55%
src/entities/Destination/routes/getDestinationsList.ts	191	214	89.25%
src/api/CommsGatekeeper.ts	40	101	39.6%
src/entities/Place/model.ts	280	400	70.0%

Totals
Change from base Build 20864026152:	-1.1%
Covered Lines:	14405
Relevant Lines:	15495

💛 - Coveralls

aleortega

Hey PR looks good to me!

Yet I left some doubts/comments to address!

aleortega · 2026-01-13T19:03:45Z

docs/openapi.yaml

+            type: integer
+            minimum: 0
+            default: 0
+        - name: positions


NIT

Hey, in our ubiquitous language, we usually refer to positions as pointers or parcels

aleortega · 2026-01-13T19:19:37Z

src/entities/Destination/routes/getDestinationsList.ts

+    if (ctx.url.searchParams.get("order_by") === PlaceListOrderBy.MOST_ACTIVE) {
+      return getDestinationsMostActiveList(ctx)
+    }


any reason for handling this case separately?

aleortega · 2026-01-13T19:27:14Z

src/entities/Destination/routes/getUnifiedDestinationsList.ts

+    getUnifiedDestinationsListQuerySchema
+  )
+
+export const getUnifiedDestinationsList = Router.memo(


same doubt on this one, would it be possible to merge all three handlers?

aleortega · 2026-01-13T19:29:17Z

docs/openapi.yaml

        '400':
          $ref: '#/components/responses/BadRequest'

+  /destinations/unified:


are we missing /destinations API Spec? anyways, do we need both endpoints? could we only have a single one?

aleortega · 2026-01-13T19:30:06Z

src/entities/Destination/routes/index.ts

+  router.get("/destinations", getDestinationsList)
+  router.get("/destinations/unified", getUnifiedDestinationsList)


do we need both endpoints? what's the difference between them? can we handle that difference with a new query or path param?

aleortega · 2026-01-13T19:31:49Z

src/entities/Destination/types.ts

+export type GetDestinationsListQuery = {
+  limit: string
+  offset: string
+  positions: string[]
+  world_names: string[]
+  only_favorites: string
+  only_highlighted: string
+  order_by: string
+  order: string
+  with_realms_detail: string
+  search: string
+  categories: string[]
+  owner?: string
+  creator_address?: string
+  only_worlds: string
+  only_places: string
+}
+
+export type DestinationsListOptions = {
+  offset: number
+  limit: number
+  only_favorites: boolean
+  only_highlighted: boolean
+  positions: string[]
+  world_names: string[]
+  order_by: string
+  order: string
+  search: string
+  categories: string[]
+  owner?: string
+  creator_address?: string
+  only_worlds: boolean
+  only_places: boolean
+}


it seems the only difference between these two types is the with_realms_detail, could we create a union so it is clear?

aleortega · 2026-01-13T19:32:05Z

src/entities/Destination/types.ts

+ * Query parameters for the unified destinations endpoint
+ * Supports filtering by coordinates (exact match), names (LIKE), search, SDK, and more
+ */
+export type GetUnifiedDestinationsListQuery = {


maybe same for this one

and the one below

aleortega · 2026-01-13T19:46:18Z

src/entities/Place/model.ts

+      ${conditional(
+        !!options.user && options.only_favorites,
+        SQL`RIGHT JOIN ${table(
+          UserFavoriteModel
+        )} uf on p.id = uf.place_id AND uf."user" = ${options.user}`
+      )}
+      ${conditional(
+        !!options.categories.length,
+        SQL`INNER JOIN ${table(
+          PlaceCategories
+        )} pc ON p.id = pc.place_id AND pc.category_id IN ${values(
+          options.categories
+        )}`
+      )}
+
+      ${conditional(
+        !!options.search,
+        SQL`, ts_rank_cd(p.textsearch, to_tsquery(${tsquery(
+          options.search || ""
+        )})) as rank`
+      )}
+
+      WHERE
+        p."disabled" is false 
+        ${conditional(options.only_highlighted, SQL`AND p.highlighted = TRUE`)}
+        ${conditional(options.only_places, SQL`AND p.world is false`)}
+        ${conditional(options.only_worlds, SQL`AND p.world is true`)}
+        ${conditional(!!options.search, SQL` AND rank > 0`)}
+        ${conditional(!!placesOrWorldsCondition, placesOrWorldsCondition)}
+        ${conditional(
+          !!options.owner,
+          SQL` AND (LOWER(p.owner) = ${options.owner} ${
+            options.operatedPositions?.length
+              ? SQL`OR p.base_position IN (
+                  SELECT DISTINCT(base_position)
+                  FROM ${table(PlacePositionModel)}
+                  WHERE position IN ${values(options.operatedPositions)}
+                )`
+              : SQL``
+          })`
+        )}
+        ${conditional(
+          !!options.creator_address,
+          SQL` AND LOWER(p.creator_address) = ${options.creator_address}`
+        )}


are we using the exact same conditions as the query? could we extract the conditionals so we only maintain a single piece of code for both things?

aleortega · 2026-01-13T19:47:22Z

src/entities/Place/model.ts

+  /**
+   * Count unified destinations with the given filters
+   */
+  static async countUnifiedDestinations(


same here, we could merge the conditionals of these two related functions

- Added `ranking` field to places and worlds schemas for custom ordering. - Updated destinations API to include `with_connected_users` query parameter, allowing retrieval of connected user wallet addresses. - Enhanced OpenAPI documentation to reflect new fields and query parameters. - Removed deprecated unified destinations endpoint and adjusted related functions and tests accordingly.

- Reformatted the environment variables section in README for improved readability. - Removed trailing whitespace in CommsGatekeeper and test files. - Cleaned up formatting in the destinations utility and routes for consistency.

- Updated method names in CommsGatekeeper from `getSceneRoomParticipants` to `getSceneParticipants` and from `getWorldRoomParticipants` to `getWorldParticipants` for improved clarity. - Adjusted related test cases and utility functions to reflect the new method names.

- Revised the description of the destinations API endpoint to clarify that it combines places and worlds with enhanced filtering capabilities, removing the mention of the deprecated unified endpoint.

…ltering - Revised the destinations API documentation to clarify sorting behavior, emphasizing the order of highlighted items, ranking, and specified sort order. - Renamed `positions` to `pointer` in the API and internal schemas for consistency. - Enhanced SDK version filtering to include places with null SDK values across relevant files. - Updated sorting logic in the PlaceModel to prioritize highlighted items, followed by ranking and activity.

- Reformatted conditional statements for SDK filtering in the PlaceModel to enhance readability and maintain consistency across the codebase.

aleortega

Hey, leaving the approve and some NIT (no-blockers) comments to iterate here or in a new PR (depending on our rush)!

aleortega · 2026-01-21T21:04:01Z

docs/openapi.yaml

+            type: integer
+            minimum: 0
+            maximum: 100
+            default: 100


NIT:
isn't default = 100 too much?

aleortega · 2026-01-21T21:05:35Z

docs/openapi.yaml

+            Filter places by specific parcel coordinates (exact match).
+            Format: `"x,y"` (e.g., `"-23,-96"`).


NIT:

Suggested change

Filter places by specific parcel coordinates (exact match).

Format: `"x,y"` (e.g., `"-23,-96"`).

Filter places by specific parcel coordinates (exact match). Worlds are excluded.

Format: `"x,y"` (e.g., `"-23,-96"`).

aleortega · 2026-01-21T21:06:44Z

docs/openapi.yaml

+        - Places
+        - Worlds
+      summary: List destinations (places + worlds)
+      security: []


NIT:

should we reference to auth-chain sec mechanism as optional since it is required for only_favorites use case?

aleortega · 2026-01-21T21:22:45Z

src/api/CommsGatekeeper.ts

+export default class CommsGatekeeper extends API {
+  static Url = env(
+    `COMMS_GATEKEEPER_URL`,
+    "https://comms-gatekeeper.decentraland.org"


NIT (default to zone to prevent hitting prod from local environment):

Suggested change

"https://comms-gatekeeper.decentraland.org"

"https://comms-gatekeeper.decentraland.zone"

aleortega · 2026-01-21T21:25:16Z

src/api/CommsGatekeeper.ts

+
+  static Cache = new Map<string, CommsGatekeeper>()
+
+  static from(url: string) {


is this used? sorry I am not used to gatsby template

Just copy the same behavior of the others API files

aleortega · 2026-01-21T21:29:36Z

src/entities/Destination/routes/getDestinationsList.ts

+
+    // Get positions from hot scenes for MOST_ACTIVE ordering
+    const hotScenesPositions =
+      query.order_by === PlaceListOrderBy.MOST_ACTIVE


hot-scenes will be only shown when this specific sorting is provided?

what about sorting order (ASC/DESC)?

aleortega · 2026-01-21T21:35:13Z

src/entities/Destination/schemas.ts

+    },
+    names: {
+      type: "array",
+      maxItems: 1000,


I think setting maxItems as 1000 will make us hit the max url length limitation imposed by browsers, can be handled client-side tho

aleortega · 2026-01-21T21:43:04Z

src/entities/Place/model.ts

+      if (hasNames) {
+        const nameLikeConditions = options.names.map(
+          (name: string) =>
+            SQL`LOWER(p.world_name) LIKE ${`%${name.toLowerCase()}%`}`
+        )


Is this a search? otherwise consider not doing a LIKE and concat .dcl.eth to the name to ensure explicit match

Yes, this is a search

aleortega · 2026-01-21T21:43:54Z

src/entities/Place/model.ts

+    if ((hasWorldNames || hasNames) && !options.only_places) {
+      const worldConditions = buildWorldConditions()
+      return SQL`AND (${join(worldConditions, SQL` OR `)})`
+    }


will this ever execute?

Yes, it will be executed in these scenarios:

No positions provided, but world_names or names are provided: positions=[], world_names=["test.dcl.eth"]

only_worlds=true with any filters: positions=["0,0"], world_names=["test.dcl.eth"], only_worlds=true

aleortega · 2026-01-21T21:47:34Z

src/entities/Place/model.ts

+      options.user && !isEthereumAddress(options.user)
+    const searchIsEmpty = options.search && options.search.length < 3
+
+    if (isMissingEthereumAddress || searchIsEmpty) {


We need to have both for the count?

…er URL - Added security requirements to the destinations API documentation, clarifying authentication options and their effects on response fields. - Updated the description for the `only_favorites` query parameter to specify behavior for unauthenticated users. - Changed the CommsGatekeeper URL to a new endpoint for improved service reliability.

- Removed the check for missing Ethereum address in the PlaceModel, streamlining the conditional logic to only validate if the search input is empty.

AndresMorelos and others added 4 commits January 13, 2026 08:10

chore: remove trailing whitespace in multiple files

961cb26

styles: Apply prettier

ee2e1fa

aleortega reviewed Jan 13, 2026

View reviewed changes

AndresMorelos added 7 commits January 16, 2026 10:10

chore: update README and clean up code formatting

3641af3

- Reformatted the environment variables section in README for improved readability. - Removed trailing whitespace in CommsGatekeeper and test files. - Cleaned up formatting in the destinations utility and routes for consistency.

refactor: improve code formatting in OverviewPage component

ae1a0dc

docs: update destinations API documentation for clarity

79dd751

- Revised the description of the destinations API endpoint to clarify that it combines places and worlds with enhanced filtering capabilities, removing the mention of the deprecated unified endpoint.

refactor: improve code formatting for SDK filtering in PlaceModel

8383b06

- Reformatted conditional statements for SDK filtering in the PlaceModel to enhance readability and maintain consistency across the codebase.

aleortega approved these changes Jan 21, 2026

View reviewed changes

AndresMorelos added 2 commits January 21, 2026 23:01

refactor: simplify conditional logic in PlaceModel

2828d76

- Removed the check for missing Ethereum address in the PlaceModel, streamlining the conditional logic to only validate if the search input is empty.

AndresMorelos merged commit 642a363 into master Jan 22, 2026
3 checks passed

AndresMorelos deleted the feat/re-discovery-changes branch January 22, 2026 13:36

		router.get("/destinations", getDestinationsList)
		router.get("/destinations/unified", getUnifiedDestinationsList)

		Filter places by specific parcel coordinates (exact match).
		Format: `"x,y"` (e.g., `"-23,-96"`).

	"https://comms-gatekeeper.decentraland.org"
	"https://comms-gatekeeper.decentraland.zone"


		static Cache = new Map<string, CommsGatekeeper>()

		static from(url: string) {

feat: add SDK version support to places and destinations #782

feat: add SDK version support to places and destinations #782

Uh oh!

Conversation

AndresMorelos commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21249696444

Details

💛 - Coveralls

Uh oh!

aleortega left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aleortega left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Jan 13, 2026 •

edited

Loading