Clock mode configurable #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacebt
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable clock mode (block number or block timestamp) to
VotesERC20StakedV1. This contract inherits from OpenZeppelin'sVotesUpgradeablewhich supports either clock mode:https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/master/contracts/governance/utils/VotesUpgradeable.sol
v0 of the Decent contracts were built to use block number for clock mode, and v1 contract were built to use block timestamp.
This contract should be able to be deployed to be used with either version of the contracts, which is why it's being made configurable here.