Cleaned up some unecessary includes, and fixed a potential null reference bug #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First - thank you for making the BlazorGridStack available as an open source project. While making use of this library in a MudBlazor app, I found that the BlazorGridStack can get into a "wonky" state where it will render fine, but none of the clicks respond. The app doesn't lock up, just the BlazorGridStack. I traced this back to a
nullablevariable (GridJS) being referenced without the nullable operator. It seems to get called multiple times during initial rendering, and if any of those times it ends up as null it will simply crash the BlazorGridStack without any user facing errors.I whipped up this quick fix and it has alleviated the issue. Please consider merging this PR so that other developers using this library don't run into this potential issue.
And I'm more than happy to make any other changes if the ones I implemented aren't up to snuff.
Thanks,
-Ben