Conversation
…position and features across tab switches
🚀 PR Preview DeployedYour PR preview has been successfully deployed to Fly.io! 🌐 Preview URL: https://pr-8-futuredebrief.fly.dev 📋 Details:
🔧 What's included:
💡 How to use:
This preview will be automatically updated when you push new commits to this PR. |
…me resolution handling
🧹 PR Preview Cleaned UpYour PR preview environment has been automatically destroyed. ✅ Cleanup successful!
All associated resources have been removed from Fly.io to optimize costs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #7: "Plot JSON Editor: Map resets to London and loses features when tab loses/regains focus"
This PR resolves the VS Code webview state persistence issue where the Plot JSON Editor map would reset to London coordinates and lose all GeoJSON features when switching between tabs.
Key Changes
Technical Implementation
PlotJsonEditorProviderwith state management and improvedonDidChangeViewStatehandlingfitBoundswhen saved state exists to prevent visual flickerFiles Modified
src/plotJsonEditor.ts- Enhanced webview lifecycle management with state persistencemedia/plotJsonEditor.js- Added state save/restore functionality and optimized restoration timingTest Plan
Before/After
Before: Tab switches → map resets to London with no features visible
After: Tab switches → map maintains position, zoom level, and displays all features instantly
Closes #7