Skip to content

Conversation

@i-meant-to-be
Copy link
Contributor

@i-meant-to-be i-meant-to-be commented Sep 10, 2025

🚩 연관 이슈

closed #370

📝 작업 내용

  • 토론 템플릿 URL 오류 수정

🏞️ 스크린샷 (선택)

없음

🗣️ 리뷰 요구사항 (선택)

없음

Summary by CodeRabbit

  • Chores
    • 여러 토론 형식(3vs3 통상, 타임식, CEDA, 열린 토론 예선/본선/결승, 준결승/결승, 2:2 자유/일반/CEDA, 의회식 등)의 공유용 인코딩 데이터를 갱신하여 최신 템플릿을 반영하고 공유 링크 일관성을 개선했습니다.
  • Style
    • OSAN시 관련 액션 라벨을 “오산시 토론 - 초/중/고등부”에서 “초등부/중등부/고등부”로 간소화해 가독성을 높였습니다.

@i-meant-to-be i-meant-to-be self-assigned this Sep 10, 2025
@i-meant-to-be i-meant-to-be added the hotfix 긴급 수정 label Sep 10, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

DEBATE_TEMPLATE의 여러 항목에서 공유 URL용 인코딩 페이로드 문자열을 교체하고, 일부 OSAN시 관련 항목의 표시 라벨을 축약했습니다. 함수 시그니처나 모듈 구조 변화는 없으며, 데이터 리터럴만 수정되었습니다.

Changes

Cohort / File(s) Summary
템플릿 공유 페이로드 갱신
src/constants/debate_template.ts
ONE/TWO/THREE 섹션 전반에서 createTableShareUrl에 사용되는 인코딩된 데이터 페이로드들을 다수 교체. 다양한 토론 형식(3vs3, 타임식, CEDA, 열린 토론 예선/본선/결승, 2:2 자유/일반/CEDA, 의회식 등)의 값 업데이트.
OSAN시 라벨 축약
src/constants/debate_template.ts
OSAN시 관련 블록의 action 라벨을 “오산시 토론 - 초등부/중등부/고등부”에서 “초등부/중등부/고등부”로 축약(ONE 및 THREE 섹션).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

fix

Suggested reviewers

  • jaeml06
  • useon

Poem

토론 시간 표를 토닥토닥, 토끼 발로 콩콩콩
길 잃은 URL은 집으로, 페이로드도 반짝 반짝
“초·중·고” 라벨은 쏙, 가벼워진 발걸음 톡
딩동—링크가 맞았다!
오늘도 타이머는 딱-딱, 토론은 싹-싹 🐇⏱️

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a18d6a7 and 4e7b4c9.

📒 Files selected for processing (1)
  • src/constants/debate_template.ts (13 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/#370

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jaeml06 jaeml06 requested review from jaeml06 and useon September 10, 2025 03:13
@i-meant-to-be i-meant-to-be merged commit 183e24f into develop Sep 10, 2025
4 of 5 checks passed
@i-meant-to-be i-meant-to-be deleted the hotfix/#370 branch September 10, 2025 03:15
@i-meant-to-be i-meant-to-be restored the hotfix/#370 branch September 23, 2025 04:52
@i-meant-to-be i-meant-to-be deleted the hotfix/#370 branch September 23, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix 긴급 수정

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[HOTFIX] 토론 템플릿 URL 오류 수정

2 participants