Skip to content

Conversation

@i-meant-to-be
Copy link
Contributor

🚩 연관 이슈

없음

📝 작업 내용

  • 반응형 타이머 적용
  • 의회식 토론 제거
  • 시간표 및 타임박스 수정 플로우 개선
  • 서비스 소개 문구 수정

🏞️ 스크린샷 (선택)

없음

🗣️ 리뷰 요구사항 (선택)

없음

katie424 and others added 7 commits May 22, 2025 13:34
* test: setup storybook viewport

* test: normal timer storybook 파일 추가

* design: 화면 크기 추가

* design: 일반타이머 반응형 구현

* design: 차례 버튼 간격 조정

* design: 작전시간타이머  반응형 구현

* design: 자유토론타이머 반응형 구현

* design: 일반타이머 최소크기 구현

* design: storybook viewport 수정

* fix: initial viewport import문 삭제
* fix: 깨진 UI 수정

* design: 콜론 위치 조정

* design: 폰트 굵기 수정
* chore: Deleted parliamentary timer

* refactor: Deleted parliamentary codes from TableListPage

* refactor: Deleted unnecessary debate types from type.ts

* refactor: Deleted parliamentary codes from Table of TableListPage

* refactor: Removed parliamentary codes from TableOverviewPage

* refactor: Removed all interfaces and type converters for parliamentary

* refactor: Removed parliamentary codes from TableCompositionPage

* refactor: Refactored CustomizeTimerPage

- Applied changes on type.ts to CustomizeTimerPage
- Renamed CustomizeTimerPage to TimerPage
  (because from now CustomizeTimerPage is a default timer)

* refactor: Disabled parliamentary API mocking

* chore: Applied timer name change on routes.tsx

* chore: Removed parliamentary API hooks

* refactor: Applied changes from type.ts to customize API hooks

* chore: Removed primitive parliamentary API codes

* refactor: Applied changes from type.ts to primitive customize API codes

* refactor: Resolve problems identified from linting

* fix: Fixed error that app requests table data on create mode

* fix: Fixed timeout button error

작전 시간 타임박스가 있음에도 불구하고 작전 시간 버튼이 표시되는 오류 수정

* refactor: Renamed API functions and response types

* fix: Fixed bug that user input doesn't applied on text field

* refactor: Typo

* chore: Resolved merge conflicts from PR #266 and #270
* chore: Deleted parliamentary timer

* refactor: Deleted parliamentary codes from TableListPage

* refactor: Deleted unnecessary debate types from type.ts

* refactor: Deleted parliamentary codes from Table of TableListPage

* refactor: Removed parliamentary codes from TableOverviewPage

* refactor: Removed all interfaces and type converters for parliamentary

* refactor: Removed parliamentary codes from TableCompositionPage

* refactor: Refactored CustomizeTimerPage

- Applied changes on type.ts to CustomizeTimerPage
- Renamed CustomizeTimerPage to TimerPage
  (because from now CustomizeTimerPage is a default timer)

* refactor: Disabled parliamentary API mocking

* chore: Applied timer name change on routes.tsx

* chore: Removed parliamentary API hooks

* refactor: Applied changes from type.ts to customize API hooks

* chore: Removed primitive parliamentary API codes

* refactor: Applied changes from type.ts to primitive customize API codes

* refactor: Resolve problems identified from linting

* fix: Fixed error that app requests table data on create mode

* fix: Fixed timeout button error

작전 시간 타임박스가 있음에도 불구하고 작전 시간 버튼이 표시되는 오류 수정

* refactor: Renamed API functions and response types

* fix: Fixed bug that user input doesn't applied on text field

* refactor: Typo

* chore: Resolved merge conflicts from PR #266 and #270

* fix: 작전시간 타이머 깨짐 수정

---------

Co-authored-by: Shawn Kang <shineksu813@outlook.com>
Co-authored-by: Shawn Kang <csm06063@naver.com>
* feat: 시간표 데이터를 세션 스토리지에 저장하기 위한 유틸함수 작성

* refactor: 타입 재활용을 위한 타입확장 활용

* feat: 레포지터리 패턴 적용을 위한 api, session 호출 로직 구현

* feat: 기존 데이터 패칭 훅에 로컬에서 데이터를 불러오는 분기 추가

* refactor: 스토리지 키값 변경

* refactor: customize 파일명 변경, request 타입 추가

* refactor: save prefix를 add로 변경
* design: Added table info edit button on TimeBoxStep

* feat: Separated initial step by current mode (edit, add)

* refactor: Changed function name on hook useFunnel

기존 함수 이름은 `goNextStep`이었고 이는 다음 스텝으로 진행한다는 의미를 내포하고 있으나, 그 의미와는 다르게 함수의 실제 역할은 다음 스텝이 아니라 매개변수로 주어진 특정 스텝이로 이동하는 기능임. 함수 이름과 기능이 일치하지 않아, 더 직관성 있는 인식을 위해 함수 이름을 더 정확하게 수정.

* feat: Added a functionality on edit table info button

* chore: development 모드에서 가짜 엑세스 토큰 설정

* chore: 리포지토리 코드 보기 좋게 수정

* refactor: Changed function name

* fix: 오류 발생 원인이 되는 코드 제거

* test: Updated test codes for TableComposition

* refactor: Fixed linting warning and error
* chore: 에셋 디렉토리 변경

* fix: 제목 텍스트 크기 통일

* chore: 메타데이터 수정
@i-meant-to-be i-meant-to-be self-assigned this May 28, 2025
@i-meant-to-be i-meant-to-be added the deploy develop에서 main으로의 배포 label May 28, 2025
@coderabbitai
Copy link

coderabbitai bot commented May 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@i-meant-to-be i-meant-to-be merged commit 25b9bf2 into main May 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy develop에서 main으로의 배포

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants