Skip to content

[FIX] 타이머에서 숫자 키패드 Enter가 동작하지 않는 문제 수정 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
i-meant-to-be merged 3 commits into from
Jul 24, 2025
Merged

[FIX] 타이머에서 숫자 키패드 Enter가 동작하지 않는 문제 수정 #17

i-meant-to-be merged 3 commits into from
Jul 24, 2025

Conversation

@i-meant-to-be
Copy link
Contributor

@i-meant-to-be i-meant-to-be commented Jul 24, 2025 •
edited by coderabbitai bot
Loading

🚩 연관 이슈

closed #16

📝 작업 내용

문제 상황

타이머에서 진영 전환은 Enter 키로 가능하지만, 숫자 키패드의 Enter 키는 인식하지 못하는 문제가 있었음

개선 사항

useTimerHotkey 훅이 NumpadEnter도 인식하도록 개선

🏞️ 스크린샷 (선택)

없음

🗣️ 리뷰 요구사항 (선택)

동일한 PR이 debate-timer-fe 저장소에서 승인되고 병합되었으므로, 이 저장소에서는 별도 PR 리뷰 없이 병합합니다.

Summary by CodeRabbit

  • 버그 수정

    • 숫자 키패드의 Enter(NumpadEnter) 키를 일반 Enter 키와 동일하게 타이머 캠프 전환 단축키로 사용할 수 있도록 개선했습니다.
    • Enter 및 NumpadEnter 키 모두에서 기본 브라우저 동작이 차단됩니다.

  • 기타

    • 버전 정보가 1.0.1로 업데이트되었습니다.

@i-meant-to-be i-meant-to-be self-assigned this Jul 24, 2025
@i-meant-to-be i-meant-to-be added the fix 버그 수정 label Jul 24, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 24, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

핫키 처리 로직에서 숫자 키패드 Enter(NumpadEnter)도 일반 Enter와 동일하게 캠프 전환 동작을 하도록 수정되었습니다. 또한, 기본 동작 방지 키 목록이 배열에서 Set으로 변경되고, NumpadEnter가 추가되었습니다. package.json의 버전도 "1.0.1"로 업데이트되었습니다.

Changes

파일/경로 변경 요약
src/page/TimerPage/hooks/useTimerHotkey.ts NumpadEnter 키를 캠프 전환 및 기본 동작 방지에 추가, Set 사용으로 변경, 주석 수정
package.json 버전 필드 "0.0.0" → "1.0.1"로 업데이트

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant TimerPage (useTimerHotkey)
  participant Browser

  User->>Browser: Enter 또는 NumpadEnter 키 입력
  Browser->>TimerPage (useTimerHotkey): keydown 이벤트 전달
  TimerPage (useTimerHotkey)->>TimerPage (useTimerHotkey): Enter/NumpadEnter 확인
  TimerPage (useTimerHotkey)->>TimerPage (useTimerHotkey): 캠프 전환 함수 실행
  TimerPage (useTimerHotkey)->>Browser: 기본 동작 방지
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

🐇
Enter도, NumpadEnter도
이제 캠프를 바꿔주네
키패드로도 신나게
토끼는 뛰며 노래해
"버전도 올랐지, 기분도 좋지!"

⌨️✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-24T05_50_57_971Z-debug-0.log

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab80df7 and fc2d600.

📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/page/TimerPage/hooks/useTimerHotkey.ts (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/#16

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@i-meant-to-be i-meant-to-be merged commit 395a0d4 into develop Jul 24, 2025
1 check passed
@i-meant-to-be i-meant-to-be deleted the fix/#16 branch July 24, 2025 05:48
@coderabbitai coderabbitai bot mentioned this pull request Aug 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@i-meant-to-be i-meant-to-be

Labels

fix 버그 수정

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FIX] 타이머에서 숫자 키패드 Enter가 동작하지 않는 문제 수정

2 participants

@i-meant-to-be