fix: fix /about route - add missing import and correct response text#40
Open
LakshmiSravyaVedantham wants to merge 1 commit intodeb2000-sudo:masterfrom
Open
Conversation
…eb2000-sudo#31) The /about route had two issues: 1. PlainTextResponse was used as response_class but never imported, causing a NameError at runtime 2. Response text was "This is all backend" instead of "This is all about backend" per the spec
LakshmiSravyaVedantham
force-pushed
the
fix/31-fix-about-route
branch
from
70fd097 to
4b0a734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from fastapi.responses import PlainTextResponseimport/aboutroute usedPlainTextResponseasresponse_classbut it was never imported, causing aNameErrorat runtimeCloses #31
Test plan
GET /aboutreturns plain text"This is all about backend"PlainTextResponse)