Conversation
|
Hi kkatsuyuki, thank you for the pull request! For now, I've only skimmed it but will look into it more thoroughly in the future, hopefully next week. It looks good, but two small remarks are (i) |
|
I made (i) and (ii) changes. |
|
Thanks kkatsuyuki. I looked at the code again, and I have some thoughts: Maybe it would be a good idea for Before merging this change I would like to have a different implementation for The current implementation does not support DBUS object redefinition very well. This will not prevent me from merging this change, but users should know this and are encouraged to submit patches. |
Though I don't have so much experiences of using dbus, I don't come up with the story that introspectable becomes harmful, so I agree. I'll adjust the code.
I also wondered if the implementation was good, so I understand your comment. I'll modify it. |
and issue an error when the child path isn't a child path of the parent object
Before this change, the child object check didn't catch a similar parent directory.
|
I've figured out that I simplified the code too much, so let me modify a little bit more. |
|
Thank you kkatsuyuki. |
I implemented introspection using mixins and added an example file for how to use it. I saw
https://gist.github.com/death/1c5780c5dcf6a838a867d8701969982f
#28
, and I tried to meet what was discussed.
Let me know any comments/requests for introspection addition. I'll consider adjusting my code.