Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
Summary
This PR adds two new bulk-crystal phonon benchmarks with Dash app integration:
Ti-6Al-4V (Ti64) phonons (
bulk_crystal/ti64_phonons)Raw outputs are written to
outputs/<model>/as<case>.npz+<case>.json.metrics.jsonplus:ti64_phonons_metrics_table.json(Dash table)ti64_phonons_interactive.json(interactive scatter)Metrics include dispersion RMSE (mean/max), ω_avg MAE, and ΔF per-atom at 0 K / 2000 K for TP-enabled cases.
Diamond phonons (bands-only) (
bulk_crystal/diamond_phonons)FORCE_CONSTANTS+band.yamlunderoutputs/<model>/. The phonon band path is taken directly from the DFT reference NPZ (dft_band.npz) so predictions match the exact reference q-path.band.yaml, sorts bands per q-point and reports Band MAE + Band RMSE (THz). Writes:diamond_phonons_bands_table.jsondiamond_phonons_bands_interactive.jsonband.yamlwith optional DFT overlay (RSCAN).Linked issue
Resolves #297
Progress
Testing
Tested both benchmarks on:
New decorators/callbacks