Skip to content

model selection #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joehart2001 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

model selection #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
149 changes: 146 additions & 3 deletions ml_peg/app/build_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
from importlib import import_module
import warnings

from dash import Dash, Input, Output, callback
from dash import Dash, Input, Output, callback, ctx, no_update
from dash.dash_table import DataTable
from dash.dcc import Store, Tab, Tabs
from dash.html import H1, H3, Div
from dash.dcc import Dropdown, Store, Tab, Tabs
from dash.exceptions import PreventUpdate
from dash.html import H1, H3, Button, Details, Div, Summary
from yaml import safe_load

from ml_peg.analysis.utils.utils import calc_table_scores, get_table_style
Expand Down Expand Up @@ -375,13 +376,85 @@ def build_tabs(
Tab(label=category_name, value=category_name) for category_name in layouts
]

model_options = [{"label": m, "value": m} for m in MODELS]

model_filter = Details(
[
Summary(
"Visible models",
style={"cursor": "pointer", "fontWeight": "bold", "padding": "5px"},
),
Div(
[
Dropdown(
id="model-filter-checklist",
options=model_options,
value=MODELS,
multi=True,
placeholder="Select visible models",
closeOnSelect=False,
style={"fontSize": "13px"},
),
Div(
[
Button(
"Select all",
id="model-filter-select-all",
n_clicks=0,
style={
"fontSize": "11px",
"padding": "4px 8px",
"backgroundColor": "#6c757d",
"color": "white",
"border": "none",
"borderRadius": "3px",
"cursor": "pointer",
},
),
Button(
"Clear",
id="model-filter-clear-all",
n_clicks=0,
style={
"fontSize": "11px",
"padding": "4px 8px",
"backgroundColor": "#6c757d",
"color": "white",
"border": "none",
"borderRadius": "3px",
"cursor": "pointer",
},
),
Comment on lines +400 to +427
Copy link
Collaborator

@ElliottKasoar ElliottKasoar Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need these when they're built into the dropdown? It adds extra complexity to the callbacks

],
style={"display": "flex", "gap": "8px", "marginTop": "8px"},
),
],
style={"padding": "8px 12px"},
),
],
id="model-filter-details",
open=True,
style={"marginBottom": "8px", "fontSize": "13px"},
)

tabs_layout = [
build_onboarding_modal(),
build_tutorial_button(),
Div(
[
H1("ML-PEG"),
Tabs(id="all-tabs", value="summary-tab", children=all_tabs),
model_filter,
Store(
id="selected-models-store",
storage_type="session",
data=MODELS,
),
Store(
id="summary-table-computed-store",
storage_type="session",
data=summary_table.data,
),
Div(id="tabs-content"),
],
style={"flex": "1", "marginBottom": "40px"},
Expand All @@ -394,6 +467,76 @@ def build_tabs(
style={"display": "flex", "flexDirection": "column", "minHeight": "100vh"},
)

@callback(
Output("model-filter-checklist", "value"),
Output("selected-models-store", "data"),
Input("model-filter-checklist", "value"),
Input("model-filter-select-all", "n_clicks"),
Input("model-filter-clear-all", "n_clicks"),
Input("selected-models-store", "data"),
prevent_initial_call=False,
)
def sync_model_filter(
checklist_value: list[str] | None,
_select_all: int,
_clear_all: int,
stored_selection: list[str] | None,
) -> tuple[list[str], list[str] | object]:
"""
Keep the model selector checklist and backing store synchronised.

Parameters
----------
checklist_value
Current selection from the model filter control.
_select_all
Click count for the "Select all" button.
_clear_all
Click count for the "Clear" button.
stored_selection
Previously persisted selection from ``selected-models-store``.

Returns
-------
tuple[list[str], list[str] | object]
Updated checklist value and store payload. The second element may be
``dash.no_update`` when only syncing from store to UI.
"""
trigger_id = ctx.triggered_id
stored = stored_selection if stored_selection is not None else MODELS

if trigger_id in (None, "selected-models-store"):
return stored, no_update
if trigger_id == "model-filter-select-all":
return MODELS, MODELS
if trigger_id == "model-filter-clear-all":
return [], []
if trigger_id == "model-filter-checklist":
selected = checklist_value or []
return selected, selected
raise PreventUpdate

@callback(
Output("model-filter-details", "open"),
Input("all-tabs", "value"),
prevent_initial_call=False,
)
def toggle_filter_panel(tab: str) -> bool:
"""
Expand the visible-models panel on the summary tab only.

Parameters
----------
tab
Currently selected tab identifier.

Returns
-------
bool
``True`` when the summary tab is active, otherwise ``False``.
"""
return tab == "summary-tab"

@callback(Output("tabs-content", "children"), Input("all-tabs", "value"))
def select_tab(tab) -> Div:
"""
Expand Down
Loading