High pressure crystals structure relaxations#340
Open
JonathanSchmidt1 wants to merge 11 commits intoddmms:mainfrom
Open
High pressure crystals structure relaxations#340JonathanSchmidt1 wants to merge 11 commits intoddmms:mainfrom
JonathanSchmidt1 wants to merge 11 commits intoddmms:mainfrom
Conversation
…l-peg into high-pressure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR authors must check the boxes below when creating the PR.
Summary
Adds a new high-pressure relaxation benchmark that evaluates MLIP performance in predicting equilibrium structures under hydrostatic pressure.
0, 25, 50, 75, 100, 125, 150 GPa
Metrics evaluated (at each pressure)
H = E + PVMethodology
janus-core'sGeomOptASE FixSymmetryconstraint used to preserve crystallographic symmetry (matching DFT protocol)FrechetCellFilterwith specified scalar pressureLinked issue
Resolves #338
Progress
Testing
Tested on the following models:
mace-mpa-0orb-v3-consv-inf-mpaNew decorators / callbacks
No new decorators or callbacks required.
Note the pull request right now includes a new model
orb-v3-consv-inf-mpabecause I wanted to compare to the original paper but this could be removed.
I am looking for some feedback on the good/bad values for the metrics