Open
Conversation
Collaborator
ElliottKasoar
left a comment
There was a problem hiding this comment.
Thanks for this! I'm testing it now, but overall it looks great! Please can you rebase as I think there are conflicts with uv.lock due to recently merged changes
Author
I hope to have addressed all comments and rebased onto main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
This benchmark introduces a check for the formation of a
Cl-Cbond in the ionic liquid BMIM Cl.Some models show a bond formation which should not happen.
The test runs
Added https://github.com/zincware/molify for creating initial configurations to the list of depedencies.
This package is the successor of https://github.com/zincware/rdkit2ase
which is already included via
https://github.com/basf/mlipx/blob/9ee4a5453aeaafc3109c2cac399de0363249367b/pyproject.toml#L21
Linked issue
Resolves #
Progress
Testing