Closed
Conversation
Collaborator
|
This has a huge number of conflicts with the level of theory changes, which need to be resolved |
| summary_data: list[dict] | None, | ||
| ) -> tuple[list[dict], list[dict], list[dict]]: | ||
| """ | ||
| Update summary table when scores/weights change, and sync on tab change. |
Collaborator
There was a problem hiding this comment.
Worth updating this too. If it's too long, you can do an extended description e.g.
Summary description.
Extended description.
Parameters
-----------
...
| full_rows, _ = update_score_style(summary_rows, stored_weights) | ||
| filtered_rows = filter_rows_by_models(full_rows, selected_models) | ||
| if filtered_rows: | ||
| filtered_scores = calc_metric_scores(filtered_rows) |
Collaborator
There was a problem hiding this comment.
Why would filter_rows_by_models not filter the scores too? Why do we need to recalculate them here and every other time filter_rows_by_models is called?
Also more generally, this pattern seems to repeat quite a big. Things like the get_table_style could maybe deal with filtered_rows being empty, which would save this if...else being repeated each time?
Collaborator
|
Superseded by #378 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Add ability to select which models are shown in the results tables
Linked issue
Resolves #190
Testing
mace models