Skip to content

Modernize library#46

Merged
ddeboer merged 1 commit intoddeboer:masterfrom
aleho:master
Feb 27, 2025
Merged

Modernize library#46
ddeboer merged 1 commit intoddeboer:masterfrom
aleho:master

Conversation

@aleho
Copy link
Contributor

@aleho aleho commented Feb 19, 2025

*) Use GitHub Actions instead of Travis
*) Use PHPUnit 10.5 code coverage
*) PHP 8.1 or greater code compatibility
*) Type hints
*) Constants
*) Final classes and interfaces for Client and Validator

This is a companion for ddeboer/vatin-bundle#30.

@aleho
Copy link
Contributor Author

aleho commented Feb 19, 2025

I wasn't sure whether you'd want to keep Scrutinizer. I can revert the changes to use PHPUnit with coverage though.

*) Use GitHub Actions instead of Travis
*) Use PHPUnit 10.5 code coverage
*) PHP 8.1 or greater code compatibility
*) Type hints
*) Constants
*) Final classes and interfaces for Client and Validator
*) Exception interface
@ddeboer
Copy link
Owner

ddeboer commented Feb 27, 2025

Fine to drop Scrutinizer!

@ddeboer ddeboer merged commit 69cf1ea into ddeboer:master Feb 27, 2025
1 check was pending
@ddeboer ddeboer mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants