Conversation
In favour of ddeboer#3 (Non EU vat numbers)
|
GB is also non-EU. |
Changed. Also added some LATAM. |
|
@ddeboer, would you merge my PR? Kind regards, |
|
Saw the PR as I needed to check some things in this repo, and merging this would make it unusable to us. Let me explain. As the repo is built it concerns EU VAT system. The VIES service, used for full validation, is strictly EU - it will never return valid results for another country (well, except Northern Ireland, but that's another story). Within EU the validity has a very practical use, as it will change how sales tax is applied. If it starts returning So first, repo owner need to decide if this is going to be a generic format validator or a formal EU VAT validator. |
|
Dear Sören,
I certainly understand that. I am thinking about a request option f.e. validateNonEU true/false and proceed from there. I am willing to apply these changes in a further PR, but will wait until further information.
If the PR is not of use, I can close it at any given time.
|
In favour of #3 (Non EU vat numbers)