Skip to content

Feature/modernize#21

Closed
Chris53897 wants to merge 6 commits intoddeboer:masterfrom
Chris53897:feature/modernize
Closed

Feature/modernize#21
Chris53897 wants to merge 6 commits intoddeboer:masterfrom
Chris53897:feature/modernize

Conversation

@Chris53897
Copy link

Hi. I modernized some things, hope you like it.

  • Add github actions
  • Update readme
  • Update dependencies
  • Remove deprecations
  • Fixes for --prefer-lowest (see last 3 entries in composer.json require-dev section.)
  • Set PHP to 7.2 (there are no infos about the desired language level) Please let me know if you wish an other php persion as lowest level.

I need to add 2 tests only to run on php > 8.
These are because of the newly added php8 attributes.
I am not sure if the php8 attributes commit is running on < php 8.
Or if this is just an problem of the tests.

Please have a look at Tests/Functional/ValidatorAnnotationTest.php if my changes are correct.

see Test-Run

@oleg-andreyev oleg-andreyev mentioned this pull request Feb 16, 2022
@ddeboer
Copy link
Owner

ddeboer commented Feb 27, 2025

Thanks! Implemented in #30.

@ddeboer ddeboer closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants