-
Notifications
You must be signed in to change notification settings - Fork 16
EBL 3.0: SD-2594,SD-2595: Remove pagination and change SMDG -> SCAC #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the EBL Endorsement API v3.0.2 by removing pagination support and changing the carrier code terminology from SMDG to SCAC. The changes include removing pagination-related query parameters (cursor, limit) and response headers (Next-Page-Cursor), updating all references from SMDG to SCAC throughout the specification, and adding a new example demonstrating multiple endorsement chains for the same transport document reference.
- Removed pagination functionality (cursor, limit parameters and Next-Page-Cursor header)
- Changed carrier code terminology from SMDG to SCAC with updated provider references (SMDG → NMFTA)
- Added example showing multiple endorsement chains for the same B/L
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
User description
SD-2594: Removed
cursor,limitquery parameters and removed theNext-Cursorheader in the responseSD-2595: Changed
SDMG->SCACAdded an extra example to show a result where there are 2 endorsement chain results for the same
transportDocumentReferencePR Type
Enhancement
Description
Removed pagination support (
limitandcursorquery parameters)Removed
Next-Page-Cursorresponse header for paginationRenamed carrier code from
SMDGtoSCACthroughout APIAdded note clarifying endpoint does not support pagination
Added new example showing multiple endorsement chains for same transport document reference
Diagram Walkthrough
File Walkthrough
EBL_END_v3.0.2.yaml
Remove pagination and update carrier code standardebl/v3/endorsement/EBL_END_v3.0.2.yaml
carrierSMDGCodeparameter and property tocarrierSCACCodewithupdated documentation referencing NMFTA instead of SMDG
limitandcursorquery parameters from the GET endpointNext-Page-Cursorresponse header and its detaileddocumentation
twoTDSRExample) demonstrating multiple endorsementchains for the same
transportDocumentReferenceEndorsementChainschema description to clarify relationshipwith transport document references