Skip to content

Conversation

@HenrikHL
Copy link
Contributor

@HenrikHL HenrikHL commented Sep 16, 2025

PR Type

Documentation


Description

  • Clarify actionCode references in Transaction object documentation

  • Improve precision of field descriptions in release notes


File Walkthrough

Relevant files
Documentation
README.md
Clarify actionCode field references                                           

pint/v3/README.md

  • Updated description text to specify actionCode field explicitly
  • Clarified that existing values refer to actionCode values
+2/-2     

@qodo-code-review
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Consistency

Ensure all references elsewhere in the docs now explicitly say actionCode and that no lingering mentions of action or ambiguous “existing values” remain; cross-check tables/examples to reflect the updated value names.

- `action` renamed to `actionCode` to align with Surrender API
- `actionCode` description updated to align with Surrender API
- existing `actionCode` values updated to align with Surrender API:
  - `ISSU` --> `ISSUE`
  - `TRNS` --> `TRANSFER`
  - `ENDO` --> `ENDORSE`
Alignment

Verify the updated actionCode description and value mappings exactly match the Surrender API spec (including case and allowed set), and confirm there are no additional codes needing mention.

- `actionCode` description updated to align with Surrender API
- existing `actionCode` values updated to align with Surrender API:
  - `ISSU` --> `ISSUE`
  - `TRNS` --> `TRANSFER`
  - `ENDO` --> `ENDORSE`

@HenrikHL HenrikHL merged commit 2b7b55a into master Sep 16, 2025
1 check passed
@HenrikHL HenrikHL deleted the HenrikHL-patch-1 branch September 16, 2025 11:28
@qodo-code-review
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants