Skip to content

Conversation

@HenrikHL
Copy link
Contributor

@HenrikHL HenrikHL commented Jun 27, 2025

User description

SD-2264: Update condition on expectedDepartureFromPlaceOfReceiptDate


PR Type

Enhancement


Description

  • Remove routing reference restriction from expected departure date condition

  • Allow shippers to provide preferred pickup dates for operational flexibility

  • Update conditional rule across three schema components


Changes walkthrough 📝

Relevant files
Enhancement
BKG_v2.0.2.yaml
Update conditional rule for expected departure date           

bkg/v2/BKG_v2.0.2.yaml

  • Remove "If routingReference is provided - this property MUST not be
    provided" restriction
  • Update conditional rule in three different schema components
  • Maintain existing mandatory conditions for vessel/voyage/service
    details
  • +3/-3     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link

    qodo-code-review bot commented Jun 27, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    SD-2264 - PR Code Verified

    Compliant requirements:

    • Update conditional rule for expectedDepartureFromPlaceOfReceiptDate to: "Mandatory if vessel/voyage/service details or expectedArrivalAtPlaceOfDeliveryDate or expectedDepartureDate (at POL) is not provided"
    • Remove the restriction that prevents providing expectedDepartureFromPlaceOfReceiptDate when routingReference is provided
    • Allow shippers to provide preferred pickup dates for operational flexibility

    Requires further human verification:

    • Support trucking pre-carriage scenarios where shippers know expected transit times
    • Enable shipper input while keeping carrier responsible for validation/adjustment at booking confirmation

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Consistency Check

    The same conditional rule change is applied to three different schema components. Verify that all three locations represent the same field and that the change is consistently applied across all relevant schema definitions.

      **Condition:** Mandatory if vessel/voyage/service details or `expectedArrivalAtPlaceOfDeliveryDate` or `expectedDepartureDate` (at POL) is not provided.
    example: '2021-05-17'

    @qodo-code-review
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @HenrikHL HenrikHL merged commit 4798350 into master Jun 27, 2025
    1 check passed
    @HenrikHL HenrikHL deleted the SD-2264_Fix-expectedDepartureFromPlaceOfReceiptDate-rule branch June 27, 2025 10:11
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants