Skip to content

Conversation

@HenrikHL
Copy link
Contributor

@HenrikHL HenrikHL commented Jun 10, 2025

User description

Rename emptyContainerPickupAnyOriginType--> originEmptyContainerPickup (plus fix Spectral)


PR Type

Enhancement


Description

• Rename schema property from emptyContainerPickupAnyOriginType to originEmptyContainerPickup
• Update schema reference from EmptyContainerPickupAnyOriginType to OriginEmptyContainerPickup
• Update schema title and deprecation notice text
• Fix Spectral linting configuration


Changes walkthrough 📝

Relevant files
Enhancement
BKG_v2.0.2.yaml
Rename empty container pickup schema property                       

bkg/v2/BKG_v2.0.2.yaml

• Rename property emptyContainerPickupAnyOriginType to
originEmptyContainerPickup in multiple schema definitions
• Update
schema reference from EmptyContainerPickupAnyOriginType to
OriginEmptyContainerPickup
• Change schema title from "Empty Container
Pickup (Any Origin Type)" to "Origin Empty Container Pickup"
• Update
deprecation notice to reference new property name

+9/-9     
Configuration changes
styleguide.json
Fix Spectral configuration                                                             

.stoplight/styleguide.json

• Update Spectral linting configuration

+1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Breaking Change

    The property name change from emptyContainerPickupAnyOriginType to originEmptyContainerPickup is a breaking change that will affect API consumers. Verify that proper versioning and migration strategy is in place.

    originEmptyContainerPickup:
      $ref: '#/components/schemas/OriginEmptyContainerPickup'
    Inconsistent Deprecation

    The deprecation notice at line 6390 references the new property name originEmptyContainerPickup but should reference the old property being deprecated. This creates confusion about which property is actually deprecated.

      **Deprecated:** In case both provider and consumer are on API v2.0.2 (or later), please use `originEmptyContainerPickup` instead as it contains no conditions.
    properties:

    @qodo-code-review
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @HenrikHL HenrikHL merged commit 6e2d74f into master Jun 10, 2025
    1 check passed
    @HenrikHL HenrikHL deleted the SD-2226_rename-emptyContainerPickupAnyOriginType branch June 10, 2025 22:06
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants