Skip to content

SD-1667 Check if files are changed which are not allowed to change #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkosternl merged 18 commits into from
Feb 17, 2025
Merged

SD-1667 Check if files are changed which are not allowed to change #493

jkosternl merged 18 commits into from
Feb 17, 2025

Conversation

@jkosternl
Copy link
Contributor

@jkosternl jkosternl commented Feb 13, 2025

Check if files are changed which are not allowed to change: add GitHub Action, with a few example file names

  • Note: RegEx pattern is allowed inside the files list.
  • Also add .gitignore to exclude default locations while working with an IDE

@jkosternl
SD-1667 Check if files are changed which are not allowed to change; a…
a3d8c3c 
…dd GitHub Action

* Also add .gitignore to exclude default locations while working with an IDE
@jkosternl jkosternl added the enhancement New feature or request label Feb 13, 2025
@jkosternl jkosternl self-assigned this Feb 13, 2025
@github-actions
Copy link

github-actions bot commented Feb 13, 2025

The following file(s) are not allowed to be changed: bkg/v1/bkg_v1.0.0-Beta-2.yaml

@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited by jkosternl
Loading

Error: The following file(s) are not allowed to be changed: bkg/v1/README.md

@github-actions
Copy link

github-actions bot commented Feb 13, 2025

Error: The following file(s) are not allowed to be changed: bkg/v1/bkg.yaml, bkg/v1/bkg.yaml

@jkosternl jkosternl requested a review from HenrikHL February 13, 2025 11:27
@HenrikHL
Copy link
Contributor

HenrikHL commented Feb 15, 2025

Looks good to me. I will make a commit updating the .github/forbidden_changes.txt with a list of published APIs/Domains.
Once updated I will approve the PR :-)

@HenrikHL
Copy link
Contributor

HenrikHL commented Feb 17, 2025

@jkosternl I am updating the .github/forbidden_changes.txt but was wondering if there is any check on the files that I enter. If I write a typo in a filename - then it will not be filed as an error?
Is it in any way possible to check (when updating the file) - that all lines in the file actually "hits" a file in the repo?

HenrikHL and others added 4 commits February 17, 2025 14:40
@HenrikHL
Update published APIs list
3685eaf 
List includes:
* APIs/Domains that have been published (and are now readOnly)
* APIs/Domains that are discontinued
* reference data (DCSA will not maintain these lists - for now)
@jkosternl
Filter out .md files (covering all readme.md). Move .gitignore to rig…
48d48e2 
…ht location and add ignored paths
@jkosternl
File allowed to change
bb4feec
@jkosternl
Not allowed to change
089d1fd
@github-actions
Copy link

github-actions bot commented Feb 17, 2025

Error: The following file(s) are not allowed to be changed: ovs_event_hub/v2/ovs_event_hub.yaml

HenrikHL
HenrikHL approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@HenrikHL HenrikHL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@jkosternl jkosternl merged commit ed14339 into master Feb 17, 2025
1 check passed
@jkosternl jkosternl deleted the SD-1667_CheckChanges branch February 17, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HenrikHL HenrikHL HenrikHL approved these changes

Assignees

@jkosternl jkosternl

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkosternl @HenrikHL