basic support for weapon settings#28
Merged
Raffson merged 10 commits intodcs-retribution:retributionfrom Mar 8, 2026
Merged
Conversation
Druss99
force-pushed
the
weaponsettings
branch
2 times, most recently
from
6aee54f to
1ef2eb2
Compare
Druss99
force-pushed
the
weaponsettings
branch
2 times, most recently
from
c6678d6 to
6a25436
Compare
mypy fixes
Druss99
force-pushed
the
weaponsettings
branch
from
a9421c5 to
e68acac
Compare
Raffson
reviewed
Feb 16, 2026
Raffson
left a comment
Raffson
left a comment
There was a problem hiding this comment.
Ok.. clearly this is something for the weekend 😅
But if my assumption is correct, Copilot wrote some of this code, and my first recommendation would be to look for similar lines as the one I pointed out and write them as we usually do using self 😁
Author
|
You're absolutely right! Copilot did write some of this code! Let me examine this more closely and make the proper fix. /s Jokes aside, yeah I started with AI and it gave me garbage so I rewrote most of it but I probably missed a few things |
Author
|
Okay this latest commit fixes the AI slop I found, I can remove a lot of the docstrings as well if you'd like since they aren't needed for 99% of the methods |
Druss99
force-pushed
the
weaponsettings
branch
from
17e7e18 to
c03fbe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.