Open
Conversation
byroot
referenced
this pull request
in byroot/charade
Dec 14, 2012
The BOM detection was comparing str instances with bytes instances. e.g. b'\xEF\xBB\xBF' == '\xEF\xBB\xBF' Test status before commit: 377 tests 25 failures Test status after commit: 382 tests 25 failures
dan-blanchard
force-pushed
the
master
branch
from
9a754c9 to
53854fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes in handy for sending it segments of very large compressed files.